export the effect function as well from entrypoint
#185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halivert
approved these changes
Oct 4, 2022
|
I've found that the effect function not being available makes it impossible to use Petite Vue as a driver of a generally usable custom element. It's a shame. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the petite-vue distribution can't be used alongside a separate installation of @vue/reactivity, it would be helpful to gain access to the
effectfunction via an export. Sinceeffectis already being used internally, it doesn't increase bundle output, andeffectcan come in handy when using global reactive state outside of a scope.